Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @babel/eslint-parser to support dynamic imports #39

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

bearfriend
Copy link
Contributor

@bearfriend bearfriend commented Feb 21, 2021

Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. Should this be released just as a patch? i.e. are there any concerns about this breaking anything downstream?

@bearfriend
Copy link
Contributor Author

Since this repo has no dependencies it could be breaking in that linting would fail if @babel/eslint-parser was not present, but it's also a dev dependency so not sure which way to go.

@dlockhart dlockhart merged commit 7a008c1 into Brightspace:master Feb 22, 2021
@dlockhart
Copy link
Member

Ok I release it as a minor release just to be safe, which will behave like a major version bump since we're still at 0.x.

@ghost
Copy link

ghost commented Feb 22, 2021

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Feb 22, 2021
@dlockhart
Copy link
Member

Confirmed in core that this is a breaking change:

Error: Failed to load parser '@babel/eslint-parser' declared in '.eslintrc.json » eslint-config-brightspace/lit-config » ./browser-config.js': Cannot find module '@babel/eslint-parser'

So good thing it was a minor/major bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants