Support Publisher Confirms from RMQ #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iancooper
commented
Apr 23, 2021
| @@ -74,7 +73,7 @@ public RmqMessageProducerConfrmationsSendMessageTests () | |||
| [Fact] | |||
| public async Task When_confirming_posting_a_message_via_the_messaging_gateway() | |||
| { | |||
| _messageProducer.Send(_message); | |||
| await _messageProducer.SendAsync(_message); | |||
There was a problem hiding this comment.
We don't support SendAsync on an RMQ producer as there is no Async method on RMQ. I'll revert then patch a fix to use a taskcompletion source so at least that code path won't throw for now
…doesn't have async support. So we wrap in a task completion source
|
@holytshirt I fixed that issue around the TaskCompletionSource for SendAsync on the RMQ message producer. Any more actions you would like to see, or move this one into master? |
holytshirt
approved these changes
May 5, 2021
honkuan86
added a commit
to honkuan86/Brighter
that referenced
this pull request
May 6, 2021
Support Publisher Confirms from RMQ (BrighterCommand#1494)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did the hard work for this under two other changes:
At that point it became fairly easy to plug RQM confirms into this model. it just needs to support the right interface and raise the event when it receives confirmation that the message has been published
Closes#275