Plumbed Channel Creation Mode into the Factories #1444 #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preardon
requested review from
DevJonny,
holytshirt and
iancooper
as code owners
|
|
preardon
force-pushed
the
bug/1444-PlumInMakeChannel
branch
from
eca5ba1 to
f049d11
Compare
…and thje ASBConsumer
|
I found another Separate Part of the Subscription that wasn't yet plumbed in, @iancooper Hope you don't mind that I added it to this PR |
|
Thanks Paul, I'll take a look asap. PS You need to add all the email addresses you submit with to your account so that are CLA system picks you up. |
|
@iancooper Thanks for looking at this, I've Added the other email address, CLA seems to be fine now. Let me know if you have any questions |
|
Looks good, and thanks for plugging that parameter through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed Plumbing in make channels in the Consumer Factory, it doesn't appear to be "Needed" in the Producer Factory as it doesn't appear to be Natively used by Brighter, however I plumbed it in for Completeness