-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka Improvements #1351
Kafka Improvements #1351
Conversation
…an be read by the new consumer
… you need to check
… successfully in container over spin. Add a README.md to distinguish developer tests (core) from automated tests (others)
… successfully in container over spin. Add a README.md to distinguish developer tests (core) from automated tests (others)
…in the Outbox prior to throwing an exception from the Command Processor
…d producer factories
…an issue with a monitor never exiting, this giving us only one scan.
The asynchronous nature of the callback, coupled with an Outbox, means I have made some changes to how producers work here:
This also revealed a couple of defects in the existing InMemoryBox code
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need a beer after reading through that. I think it looks okay so going to bring it in after the tests work.
Merge had to a bit of manual merging locally due to the json stuff, but all fixed now |
Thanks mate |
The real issue is the failures around the CI for Kafka. It's not clear what is going wrong, but I think is post my adding the tests that run on Confluent |
The Kafka client is not fit for prime time right now, it has some glaring problems such as the inability to set a partition key, and problems around how the consumer handles errors. This PR will fix that