From 57fd70fc7d3918a6bd4c714fe479488391a563f6 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Thu, 4 Apr 2019 16:44:34 +0200 Subject: [PATCH] stream: remove TODO and add a description instead After looking into this it turned out that these two errors are sanity checks that should not be reached. It is unfortunate that we assigned error codes for these but changing it into an assertion seems to be a hassle for `readable-streams`. PR-URL: https://github.com/nodejs/node/pull/27086 Reviewed-By: James M Snell Reviewed-By: Matteo Collina Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott --- lib/_stream_transform.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/_stream_transform.js b/lib/_stream_transform.js index ab6ada8dec0a4f..b4fffaa98891cd 100644 --- a/lib/_stream_transform.js +++ b/lib/_stream_transform.js @@ -209,9 +209,7 @@ function done(stream, er, data) { if (data != null) // Single equals check for both `null` and `undefined` stream.push(data); - // TODO(BridgeAR): Write a test for these two error cases - // if there's nothing in the write buffer, then that means - // that nothing more will ever be provided + // These two error cases are coherence checks that can likely not be tested. if (stream._writableState.length) throw new ERR_TRANSFORM_WITH_LENGTH_0();