From 5164a12618cf60150db621aebe1f3d89efb9b9aa Mon Sep 17 00:00:00 2001 From: leeseean Date: Tue, 14 Nov 2017 16:15:25 +0800 Subject: [PATCH] http: use strict comparison PR-URL: https://github.com/nodejs/node/pull/17011 Reviewed-By: Anna Henningsen Reviewed-By: Tiancheng "Timothy" Gu --- lib/_http_client.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/_http_client.js b/lib/_http_client.js index 74bec38b6e669e..a9ee686c69a67f 100644 --- a/lib/_http_client.js +++ b/lib/_http_client.js @@ -44,7 +44,7 @@ const errors = require('internal/errors'); const INVALID_PATH_REGEX = /[^\u0021-\u00ff]/; function validateHost(host, name) { - if (host != null && typeof host !== 'string') { + if (host !== null && host !== undefined && typeof host !== 'string') { throw new errors.TypeError('ERR_INVALID_ARG_TYPE', `options.${name}`, ['string', 'undefined', 'null'], host); } @@ -113,7 +113,7 @@ function ClientRequest(options, cb) { var method = options.method; var methodIsString = (typeof method === 'string'); - if (method != null && !methodIsString) { + if (method !== null && method !== undefined && !methodIsString) { throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'method', 'string', method); }