We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double checking some things I noticed from reviewing #123. The following need to be investigated:
The implicit type mapping tuple: Tuple[str, ...] should probably be added here:
tuple: Tuple[str, ...]
cyclopts/cyclopts/_convert.py
Line 48 in 751e8b1
def resolve_unparameterized_type(type_: Type) -> Type: return _implicit_iterable_type_mapping.get(type_, type_)
This Any -> str type coercion should probably be moved into either resolve or _convert:
Any
str
resolve
_convert
Line 292 in 751e8b1
converter not properly passed along here:
converter
Line 135 in 751e8b1
This Union check probably needs a similar fix as in Support python310 pipe unions. #80:
Union
cyclopts/cyclopts/help.py
Line 193 in 751e8b1
The text was updated successfully, but these errors were encountered:
Turns out only the first concern was real; addressed in #125 .
Sorry, something went wrong.
No branches or pull requests
Double checking some things I noticed from reviewing #123. The following need to be investigated:
The implicit type mapping
tuple: Tuple[str, ...]
should probably be added here:cyclopts/cyclopts/_convert.py
Line 48 in 751e8b1
This
Any
->str
type coercion should probably be moved into eitherresolve
or_convert
:cyclopts/cyclopts/_convert.py
Line 292 in 751e8b1
converter
not properly passed along here:cyclopts/cyclopts/_convert.py
Line 135 in 751e8b1
This
Union
check probably needs a similar fix as in Support python310 pipe unions. #80:cyclopts/cyclopts/help.py
Line 193 in 751e8b1
The text was updated successfully, but these errors were encountered: