Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OkHttp 4.x #36

Closed
fondesa opened this issue Mar 28, 2020 · 1 comment
Closed

Update to OkHttp 4.x #36

fondesa opened this issue Mar 28, 2020 · 1 comment

Comments

@fondesa
Copy link
Contributor

fondesa commented Mar 28, 2020

Currently, this plugin depends on the version 3.8.1 of OkHttp.
Not all the methods in OkHttp 4.x are backwards-compatible with the version 3.x.
If this plugin is used as implementation in :buildSrc and OkHttp 4.x is transitively brought in, the other dependencies may break if they use a backwards-incompatible API.

Currently, I'm forcing this plugin to use the version 4.x.

e.g.

configurations.all {
    resolutionStrategy.eachDependency { DependencyResolveDetails details ->
        if (details.requested.group == "com.squareup.okhttp3" && details.requested.name == "okhttp") {
            details.useVersion "4.0.0"
            details.because "Fixes \"com.github.breadmoirai:github-release\" since it doesn't depend on OkHttp 4."
        }
    }
}
@yschimke
Copy link

yschimke commented Aug 9, 2021

This 307 redirect handling should be fixed in recent OkHttp versions, see this PR https://github.com/square/okhttp/pull/5990/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants