Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Skycrapers Cell For Number Case Rule #868

Open
willyoung366 opened this issue Oct 29, 2024 · 1 comment
Open

[BUG] Skycrapers Cell For Number Case Rule #868

willyoung366 opened this issue Oct 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@willyoung366
Copy link
Collaborator

Description

In Skyscrapers, if you select Cell for Number case rule, a popup tells you to select the number to be added. This popup has a cancel button, but it does not work. When you press cancel, the popup does not go away.

Steps to Reproduce

  1. Open 4x4 skyscrapers easy1 (I think this bug exists on all boards though)
  2. Select case rules
  3. Select cell for number
  4. Select cancel (the popup won't go away)

Expected Behavior

I expected the popup to go away when you press cancel

Screenshots

{7F68209F-4BBF-46B9-8F48-EFD1B958C2C7}

Puzzle Files

No response

Additional Context

No response

@willyoung366 willyoung366 added the bug Something isn't working label Oct 29, 2024
@jadeandtea jadeandtea changed the title Skycrapers cell for number bug [BUG] Skycrapers cell for number bug Oct 29, 2024
@jadeandtea jadeandtea changed the title [BUG] Skycrapers cell for number bug [BUG] Skycrapers Cell For Number Case Rule Oct 29, 2024
@jadeandtea
Copy link
Collaborator

I looked into it a little bit; The case rule requires a number to fill in the row or column with, so there is a popup for the number to add. The popup window is in a do-while loop and waits until the number is set to something before moving on, which explains why the window doesn't close. It's in the getCaseBoard function within /skyscrapers/rules/CellForNumberCaseRule. However, if you cancel without selecting a number, the engine throws an error because there is no way to cancel a case rule after selecting it. Theoretically, if there is a way to tell the program to exit case rule mode, it would resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants