Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor help file #76

Closed
1 of 2 tasks
s0lst1ce opened this issue Nov 6, 2019 · 3 comments
Closed
1 of 2 tasks

Refactor help file #76

s0lst1ce opened this issue Nov 6, 2019 · 3 comments
Assignees
@s0lst1ce
Labels
enhancement New feature or request quality all issues which only affect the way code is written and that won't affect functionnality

Comments

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented Nov 6, 2019 •
edited
Loading

My feature request is about

  • A new feature
  • Changing a feature

Description of the solution I'd like
The code in help is currently very redundant. It could be refactored by making a Paginator class. This would also broaden its capabilities.

Alternatives I've considered
We could also just make more methods to Help

Additional context
See Paginate in dpy docs.

What needs to be done

  • Refactor code
  • Make Paginator class
@s0lst1ce s0lst1ce added enhancement New feature or request quality all issues which only affect the way code is written and that won't affect functionnality labels Nov 6, 2019
@s0lst1ce s0lst1ce self-assigned this Nov 6, 2019
@s0lst1ce
Copy link
Collaborator Author

s0lst1ce commented Nov 6, 2019

This is linked to #18

@s0lst1ce
Copy link
Collaborator Author

This is now done.

@s0lst1ce
Copy link
Collaborator Author

Paginate was dropped and simply isn't used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s0lst1ce s0lst1ce

Labels
enhancement New feature or request quality all issues which only affect the way code is written and that won't affect functionnality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s0lst1ce