Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip misplaced #3499

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Tooltip misplaced #3499

merged 2 commits into from
Mar 3, 2020

Conversation

Aaron-Bird
Copy link
Contributor

Description

Tooltip misplaced when scrolling down.
#3490 (review)

before before

Issue fixed

after after

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 26, 2020
@Flexo013
Copy link
Contributor

I am not experiencing this issue on Windows 10 with Boostnote 0.15.0.

@Aaron-Bird
Copy link
Contributor Author

I am not experiencing this issue on Windows 10 with Boostnote 0.15.0.

The triggering process of this bug:

1 Add some folders to show scroll bars
1
2 Collapse menu
2
3 Scroll down the menu
3
4 Hover the mouse over the menu.This tooltip is misplaced.

4

ZeroX-DG
ZeroX-DG approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very gud, YOU SHALL GET PASS. LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 3, 2020
@Rokt33r Rokt33r added this to the v0.15.1 milestone Mar 3, 2020
@Rokt33r Rokt33r merged commit 9549355 into BoostIO:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
approved 👍 Pull request has been approved by sufficient reviewers.
Projects
None yet
Milestone
v0.15.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Aaron-Bird @Flexo013 @ZeroX-DG @Rokt33r