Dropdown colour (theme aware) #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added rtl toggle button * added rtl toggle button * keep code styling aligned to the left and ltr at all times * added hotkey setting for direction toggle * fixed requested changes * fix undefined variable * Copyright info update updated Copyright (C) 2017 - 2019 BoostIO to Copyright (C) 2017 - 2020 BoostIO * Refine Chinese translation - Should not translate "space", it means space key in most context - Should translate "keymap", "spellcheck disabled", "auto detect" - Should translate "On Right Click" to "右键点击" - Refine misc translation. * Added Wiki Link * Add Traditional Chinese option to build.md * Bug fix (sets tabWith to 2 on prettier configuration and ConfigManager so checkboxes can be clikable) Co-authored-by: ibraude <[email protected]> Co-authored-by: Junyoung Choi <[email protected]> Co-authored-by: Satyendra <[email protected]> Co-authored-by: Andrew <[email protected]>
…55_dropdown-colour
ZeroX-DG
added
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm adding the requested changes for PR #3456 - @MiloTodt I hope that's OK.
Changed to the new
apply-themeintroduced with the Nord theme.It would be great if we could change the loop inside NoteList.styl to only use $themes var. But adding the other names to the variable in index.styl was not working.
Created an issue in NoteItemSimple.styl, so I've kept the two loops.
Issue fixed
#3455
Type of changes
Checklist: