Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine Chinese translation #3425

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Refine Chinese translation #3425

merged 1 commit into from
Jan 29, 2020

Conversation

andysim3d
Copy link
Contributor

  • Should not translate "space", it means space key in most context
  • Should translate "keymap", "spellcheck disabled", "auto detect"
  • Should translate "On Right Click" to "右键点击"
  • Refine misc translation.

Description

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • 🔘 Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@andysim3d
Refine Chinese translation
fb97aab 
- Should not translate "space", it means space key in most context
- Should translate "keymap", "spellcheck disabled", "auto detect"
- Should translate "On Right Click" to "右键点击"
- Refine misc translation.
@ZeroX-DG ZeroX-DG added awaiting review ❇️ Pull request is awaiting a review. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Jan 9, 2020
@ZeroX-DG
Copy link
Member

@andysim3d can you introduce someone to review this PR? I need at least 1 more review from other people to approve this PR

@andysim3d
Copy link
Contributor Author

@qz267 could you help?

@andysim3d
Copy link
Contributor Author

Or @silverwzw

silverwzw
silverwzw approved these changes Jan 17, 2020
View reviewed changes
Copy link

@silverwzw silverwzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me - I'm not a contributor of this project though.

@ZeroX-DG
Copy link
Member

Alright, more reviews are welcome:) I'll let this open for about a week for any more review. If all are happy then we will merge this.

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 29, 2020
@Rokt33r Rokt33r merged commit 5105bab into BoostIO:master Jan 29, 2020
@Rokt33r Rokt33r removed approved 👍 Pull request has been approved by sufficient reviewers. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Jan 29, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@silverwzw silverwzw silverwzw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andysim3d @ZeroX-DG @silverwzw @Rokt33r