Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HotkeyTab accidentally set incomplete hotkey, related #3190 #3194

Merged
merged 1 commit into from
Sep 2, 2019
Merged

fix: HotkeyTab accidentally set incomplete hotkey, related #3190 #3194

merged 1 commit into from
Sep 2, 2019

Conversation

hikerpig
Copy link
Contributor

@hikerpig hikerpig commented Aug 1, 2019 •
edited by issuehunt-oss bot
Loading

Description

Bug reason

Error is thrown in CodeEditor.js due to undefined hotkey input.

function translateHotkey (hotkey) {
  return hotkey.replace(/\s*\+\s*/g, '-').replace(/Command/g, 'Cmd').replace(/Control/g, 'Ctrl')
}

Solution

HotkeyTab should always emit complete hotkeymap.

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
IssueHunt Summary

Referenced issues

This pull request has been submitted to:

IssueHunt has been backed by the following sponsors. Become a sponsor

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Aug 25, 2019
ZeroX-DG
ZeroX-DG approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 31, 2019
@Rokt33r Rokt33r merged commit e9975d1 into BoostIO:master Sep 2, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Sep 2, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Sep 2, 2019
@Rokt33r Rokt33r mentioned this pull request Sep 5, 2019
Closed
@hikerpig hikerpig deleted the bugfix/hotkeyBug branch September 5, 2019 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hikerpig @ZeroX-DG @Rokt33r