Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2935 #3180

Merged
merged 1 commit into from
Oct 10, 2019
Merged

fix #2935 #3180

merged 1 commit into from
Oct 10, 2019

Conversation

alwxkxk
Copy link
Contributor

@alwxkxk alwxkxk commented Jul 29, 2019

Description

fix #2935
Replicate the problem:

  • select one note , [Ctrl+n] (create new Note) then selete other notes.
  • select one note, [Ctrl + left click] text editor then selete other notes.

Clean the state of shiftKey and ctrlKey when blur on NoteList.

Issue fixed

Type of changes

  • ✅ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ✅ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Aug 2, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 21, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Oct 10, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Oct 10, 2019
@Rokt33r Rokt33r merged commit 59f8425 into BoostIO:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(?): Selecting multiple notes when opening them
3 participants