-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2858 - Will no longer attempt to redraw images that are already of the correct rotation #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master to fork
Fork update
Fix locale json format, add some translations
ZeroX-DG
requested changes
Apr 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small adjustment needs to be made 😄
ZeroX-DG
added
awaiting changes 🖊️
Pull request has been reviewed, but contributor needs to make changes.
and removed
awaiting review ❇️
Pull request is awaiting a review.
labels
Apr 4, 2019
ZeroX-DG
approved these changes
Apr 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 I have restarted the pipeline to apply the fix and everything is fine now.
ZeroX-DG
added
approved 👍
Pull request has been approved by sufficient reviewers.
and removed
awaiting changes 🖊️
Pull request has been reviewed, but contributor needs to make changes.
labels
Apr 13, 2019
ZeroX-DG
added
the
needs extra review 🔎
Pull request requires review from an additional reviewer.
label
Apr 13, 2019
Rokt33r
removed
needs extra review 🔎
Pull request requires review from an additional reviewer.
approved 👍
Pull request has been approved by sufficient reviewers.
labels
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Boostnote calls a "fixRotate" function on all dropped images. This works by creating a canvas, redrawing the image, and then saving the canvas. This means that all images were being saved as base64, which inflated filesizes.
This fix makes it so that any image that is already of the correct rotation (the vast majority of them) does not go through the fixRotate call, and their filesize does not increase.
Before import:
During import (the console.logs have been removed before submission):
After importing the pictures and exporting the note. The filesize of the image that had correct rotation in the first place is not changed. Note how the one which had the wrong rotation has grown.
Issue fixed
fix #2858
Type of changes
Checklist: