add Nord editor theme #2887
Merged
add Nord editor theme #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also added a PR to the codemirror repo for the nord theme, maybe it will streamline the theme loading for the editor 😉codemirror/codemirror5#5782 |
ZeroX-DG
requested changes
May 4, 2019
browser/lib/consts.js
Outdated
| themes.splice(themes.indexOf('solarized'), 1, 'solarized dark', 'solarized light') | ||
| const isProduction = process.env.NODE_ENV === 'production' | ||
| const paths = [ | ||
| isProduction ? path.join(app.getAppPath(), './node_modules/codemirror/theme') : path.resolve('./node_modules/codemirror/theme'), |
There was a problem hiding this comment.
Just one small request, this path string repeated 2 times. Can you put it in a variable?
ZeroX-DG
added
awaiting changes 🖊️
ZeroX-DG
added
approved 👍
Rokt33r
removed
needs extra review 🔎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the Nord theme as an editor theme.
The following screen shot uses both Nord theme (UI and editor):
Issue fixed
Type of changes
Checklist: