Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Cloning a note will now clone more note properties #2868

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

dredav
Copy link
Contributor

@dredav dredav commented Feb 6, 2019

Description

Cloning a note will now copy the missing following note properties to the new note

  • description
  • snippets
  • tags
  • isStarred

I'm adding the properties tags and isStarred also to this PR because I'm sure after clone a note with tag they should also be on the new note.

Issue fixed

#2859 Cloning of snippets doesn't work (win 10)

Type of changes

  • 🔵 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔵 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔵 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

…perties description, snippets, tags and isStarred
@dredav dredav changed the title [Fix] Cloning a note will now also clone more properties [Fix] Cloning a note will now clone more note properties Feb 7, 2019
@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Feb 8, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 7, 2019
@Rokt33r Rokt33r merged commit 46ecf0a into BoostIO:master Mar 20, 2019
@Rokt33r Rokt33r removed approved 👍 Pull request has been approved by sufficient reviewers. labels Mar 20, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Mar 20, 2019
@Rokt33r Rokt33r removed needs extra review 🔎 Pull request requires review from an additional reviewer. labels Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants