Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1995 #2748

Closed
wants to merge 1 commit into from
Closed

fix issue #1995 #2748

wants to merge 1 commit into from

Conversation

roottool
Copy link
Contributor

Description

I fixed that code block can not render space correctly.
This bug occurred because a monospaced font was not used on Windows.
Segoe UI default setting on Windows is not a monospaced font.

Fixed pitch | False

The reason for moving the definition position of Consolas is that it is a monospaced font.

Consolas is aimed for use in programming environments and other circumstances where a monospaced font is specified.
Fixed pitch | True

Why fixed only Windows?

Consolas is included only on Windows or Office Mac.
And I saw the comment that it did not occur on OS X.

Before

before

After

after

Issue fixed

#1995

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Dec 26, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jan 6, 2019

This bug also doesn't occur on Linux. I can't test this because I'm using Linux. I'll have to leave this to @Rokt33r

@Rokt33r
Copy link
Member

Rokt33r commented Jan 23, 2019

@roottool I think we have to change default font rather than monkey patching inside of preview.

Could you make another pr that changes default editor font to Consolas for Windows?

Please change browser/main/lib/ConfigManager.js#41
Before: fontFamily: win ? 'Segoe UI' : 'Monaco, Consolas'
After: fontFamily: win ? 'Consolas' : 'Monaco'

@Rokt33r Rokt33r closed this Jan 23, 2019
@roottool roottool deleted the fix-issue#1995 branch January 29, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review ❇️ Pull request is awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants