Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Chinese translation in preference page #2493

Merged
merged 5 commits into from
Mar 20, 2019

Conversation

opw0011
Copy link
Contributor

@opw0011 opw0011 commented Oct 13, 2018

This MR added missing translation in preference page for traditional Chinese and simplified Chinese.

default

@ZeroX-DG ZeroX-DG added help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! awaiting review ❇️ Pull request is awaiting a review. labels Oct 16, 2018
@ZeroX-DG
Copy link
Member

Is there anyone you know who speak Chinese to review this PR?

@IvanIFChen
Copy link
Contributor

I am a native Chinese speaker (from Taiwan), I can help review.

locales/zh-TW.json Outdated Show resolved Hide resolved
locales/zh-CN.json Outdated Show resolved Hide resolved
@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 10, 2018
@opw0011
Copy link
Contributor Author

opw0011 commented Nov 11, 2018

@IvanIFChen thanks for your help!

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Dec 6, 2018

@opw0011 can you solve the conflict?

@ZeroX-DG
Copy link
Member

@opw0011 Ping!

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Feb 2, 2019
@Rokt33r Rokt33r merged commit bbbbe9a into BoostIO:master Mar 20, 2019
@Rokt33r Rokt33r removed approved 👍 Pull request has been approved by sufficient reviewers. labels Mar 20, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants