Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy to clipboard"-button scrolls view to the top in toggle mode #2911

Closed
Flexo013 opened this issue Mar 4, 2019 · 3 comments
Closed

"Copy to clipboard"-button scrolls view to the top in toggle mode #2911

Flexo013 opened this issue Mar 4, 2019 · 3 comments
Labels
bug 🐛 Issue concerns a bug.

Comments

@Flexo013
Copy link
Contributor

Flexo013 commented Mar 4, 2019

Current behavior

On a long markdown note clicking the "copy to clipboard" on a code block scrolls the note all the way to the top.

Expected behavior

The view should not be changed by the "copy to clipboard" button.

Steps to reproduce

  1. Have a long markdown note, with a code block at the bottom using triple quotes.
  2. Make sure to use the toggle mode view (not the side by side view).
  3. Click the "copy to clipboard" on the code block.
  4. The copying goes through but the note is also scrolled to the top.

Environment

  • Version : 0.11.15
  • OS Version and name : Windows 10 and Ubuntu 16.04
@ZeroX-DG ZeroX-DG added needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. bug 🐛 Issue concerns a bug. and removed needs investigation 🔬 Issue requires further investigation to locate or narrow down the problem. labels Mar 7, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Mar 7, 2019

I submitted a PR for this: #2914. Thank you for reporting.

@Flexo013
Copy link
Contributor Author

@ZeroX-DG Should I be the one to close this issue as the PR is merged? Or should that be done once this big fix is released?

@ZeroX-DG
Copy link
Member

I didn't realize that it was merged. I'll close this issue. Thanks for reminding me, mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
None yet
Development

No branches or pull requests

2 participants