Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not output return as last statement #92

Open
rfalke opened this issue Oct 3, 2018 · 0 comments
Open

Do not output return as last statement #92

rfalke opened this issue Oct 3, 2018 · 0 comments
Labels
dom: codegen (P/I) Related to high level code output type: bug (I) Something is not working as intended

Comments

@rfalke
Copy link

rfalke commented Oct 3, 2018

Exe: https://github.com/rfalke/decompiler-subjects/blob/master/from_holdec/dmi/cfg/ia32_elf/subject.exe
Boomerang: boomerang-cli v0.3.99-alpha-1757-gd6a5867

Output (see https://github.com/rfalke/decompiler-subjects/blob/master/from_holdec/dmi/cfg/ia32_elf/by_boomerang-ng.c):

void basic_1_if(__size32 param1)
{
    if (param1 == 42) {
        puts("if block");
    }
    else {
    }
    return;
}

The return without a value as the last statement is just noise and serves no purpose.

@ceeac ceeac added type: bug (I) Something is not working as intended dom: codegen (P/I) Related to high level code output labels Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dom: codegen (P/I) Related to high level code output type: bug (I) Something is not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants