Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image replacement is case-sensitive when it should not be #5095

Closed
DanielGordonIT opened this issue Jul 3, 2024 · 1 comment · Fixed by #5096
Closed

Image replacement is case-sensitive when it should not be #5095

DanielGordonIT opened this issue Jul 3, 2024 · 1 comment · Fixed by #5096
Labels
🐛 Bug
Milestone
BookStack v24.05.3

Comments

@DanielGordonIT
Copy link
Contributor

Describe the Bug

When replacing an image in the image editor, if the case of the extension differs the replacement fails.

Steps to Reproduce

  1. Upload an image named "file.PNG"
  2. Attempt to replace the image with "newfile.png"
  3. Observe the error

Expected Behaviour

As png and PNG are not indicators of different files, you should be able to replace a file ending in PNG with one ending in png.

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v24.02.2
@DanielGordonIT DanielGordonIT mentioned this issue Jul 3, 2024
Merged
@DanielGordonIT
Copy link
Contributor Author

Pull request wrapping the relevant segments of code in strtolower() has been created

@ssddanbrown ssddanbrown added this to the BookStack v24.05.3 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug
Milestone
BookStack v24.05.3
Development

Successfully merging a pull request may close this issue.

Wraps file extension comparison components in strtolower() DanielGordonIT/BookStack
2 participants
@ssddanbrown @DanielGordonIT