Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Center Videos #3378

Closed
WavedirectTel opened this issue Apr 7, 2022 · 1 comment
Closed

Unable to Center Videos #3378

WavedirectTel opened this issue Apr 7, 2022 · 1 comment
Labels
Milestone

Comments

@WavedirectTel
Copy link

Describe the Bug

When you select an embedded video. Using the left/right/center formatting buttons will not center the video.

Wrapping it with html with

will center it and work.

Steps to Reproduce

Embed the video using the media button.
Highlight the video
Click on Center / Left / Right.
Nothing happens.

Expected Behaviour

The video should shift left/right/center.

Screenshots or Additional Context

Disabled all browser extensions to be sure.

Browser Details

Brave, Firefox.

Exact BookStack Version

v22.0.3.1

PHP Version

7.4.3

Hosting Environment

Ubuntu 20.04

@ssddanbrown
Copy link
Member

Thanks @WavedirectTel for raising.
I have now implemented better video alignment, copying that of images, via PR #4727 although the implementation works around complications from the editor, so the fix was tricker than hoped and may be somewhat brittle, but it will be part of the next feature release so I'll therefore close this off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants