Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller refactor #76

Merged
merged 9 commits into from
Mar 5, 2019
Merged

Conversation

juangallostra
Copy link
Member

@juangallostra juangallostra commented Mar 5, 2019

Description of the issue/feature this PR addresses

Related issues: #58 #59

  1. Refactor the code of the Rate and Level controllers
  2. Fix some control-action related computations that were a bit weird
  3. Tune some of the filter parameters

Current behavior before PR

The Mosquito can be flown but it is hard to do so since it has some inherent drift and it is not really stable.

Desired behavior after PR is merged

It is easier to fly the Mosquito and its behavior is more stable.

@juangallostra juangallostra added enhancement New feature or request next release labels Mar 5, 2019
@juangallostra juangallostra self-assigned this Mar 5, 2019
@juangallostra juangallostra requested a review from PepMS March 5, 2019 08:34
src/pidcontrollers/rate.hpp Outdated Show resolved Hide resolved
src/pidcontrollers/rate.hpp Outdated Show resolved Hide resolved
@@ -48,31 +48,47 @@ hf::SBUS_Receiver rc = hf::SBUS_Receiver(CHANNEL_MAP, SERIAL_SBUS, &SBUS_SERIAL)

hf::MixerQuadX mixer;

// Rate Constants
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are constants for Mosquito 90. When we launch the release, we may provide the parametrized sketch along with param files to configure properly either the Mosquito 90 and the Mosquito 150.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put them in a separate file so that we can keep track of them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juangallostra juangallostra merged commit 6de87fd into filter-integration Mar 5, 2019
@juangallostra juangallostra deleted the controller-refactor branch March 5, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants