Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of CubicSymbol #194

Merged
merged 19 commits into from
May 2, 2020
Merged

Draft of CubicSymbol #194

merged 19 commits into from
May 2, 2020

Commits on Apr 11, 2020

  1. Draft of CubicSymbol

    @federico-bongiorno
    federico-bongiorno committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    27feeae View commit details
    Browse the repository at this point in the history

  2. Edited arithmoi.cabal

    @federico-bongiorno
    federico-bongiorno committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    8c7cb1e View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2020

  1. Extended function to all integers and defined operations for CubicSym… 

    …bol.
    @federico-bongiorno
    federico-bongiorno committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    ad0d206 View commit details
    Browse the repository at this point in the history

  2. Addressed comments on pattern matching

    @federico-bongiorno
    federico-bongiorno committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    72ce88f View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Changed the implementation of the cubicSymbol function and added comm… 

    …ents.
    @federico-bongiorno
    federico-bongiorno committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    d08fc9f View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Added modular arithmetic, imported functions and error messages.

    @federico-bongiorno
    federico-bongiorno committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    d9ea713 View commit details
    Browse the repository at this point in the history

  2. Corrected edge cases. Simplified code by adding cubicReciprocity func… 

    …tion. No use of E.associates.
    @federico-bongiorno
    federico-bongiorno committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    a05b4b6 View commit details
    Browse the repository at this point in the history

  3. Got rid of factoriseBadPrime, changed line spacing and updated comments.

    @federico-bongiorno
    federico-bongiorno committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    97f4270 View commit details
    Browse the repository at this point in the history

  4. Tidied up code

    @federico-bongiorno
    federico-bongiorno committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    03b7df7 View commit details
    Browse the repository at this point in the history

  5. Improvements to getPrimaryDecomposition function

    @federico-bongiorno
    federico-bongiorno committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    8ab434b View commit details
    Browse the repository at this point in the history

  6. More readable code in getPrimaryDecomposition

    @federico-bongiorno
    federico-bongiorno committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    4730d19 View commit details
    Browse the repository at this point in the history

  7. Added test to check cubicSymbol when the denominator is prime

    @federico-bongiorno
    federico-bongiorno committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    eac987b View commit details
    Browse the repository at this point in the history

  8. Minor change to cubicSymbol3 test function

    @federico-bongiorno
    federico-bongiorno committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    0533ff6 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2020

  1. Helper functions return cubic symbols rather than integers

    @federico-bongiorno
    federico-bongiorno committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    4043c6c View commit details
    Browse the repository at this point in the history

  2. Added symbolToNum and exponentiation. Changed extractPrimaryContribut… 

    …ions
    @federico-bongiorno
    federico-bongiorno committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    20ab1b8 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Updating with master

    @federico-bongiorno
    federico-bongiorno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    b00093b View commit details
    Browse the repository at this point in the history

  2. Added table lookup for getPrimaryDecomposition

    @federico-bongiorno
    federico-bongiorno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    88a218d View commit details
    Browse the repository at this point in the history

Commits on May 2, 2020

  1. Added Haddock comments

    @federico-bongiorno
    federico-bongiorno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    eb9e5ee View commit details
    Browse the repository at this point in the history

  2. Changed comments and avoided compiler warning

    @federico-bongiorno
    federico-bongiorno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    c4ad23b View commit details
    Browse the repository at this point in the history