Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize for reading a{sv} messages and headers #98

Merged
merged 2 commits into from
Oct 9, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 9, 2022

closes #90

about 7% speed up.

The RPI3 can almost keep up with 4 adapters now. The python overhead downline is now more expensive after this PR so likely effort needs to shift back to bleak and HA.

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 81.57% // Head: 81.72% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (5717503) compared to base (2c6ee99).
Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   81.57%   81.72%   +0.15%     
==========================================
  Files          25       25              
  Lines        2941     2966      +25     
  Branches      567      573       +6     
==========================================
+ Hits         2399     2424      +25     
+ Misses        335      334       -1     
- Partials      207      208       +1     
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/_private/unmarshaller.py 96.45% <96.96%> (-0.05%) ⬇️
src/dbus_fast/message_bus.py 72.43% <0.00%> (-0.77%) ⬇️
src/dbus_fast/glib/message_bus.py 83.12% <0.00%> (+2.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review October 9, 2022 21:59
@bdraco bdraco merged commit 4648d29 into main Oct 9, 2022
@bdraco bdraco deleted the inline_asv branch October 9, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize for a{sv}
1 participant