Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve performance of unmarshalling headers #88

Merged
merged 3 commits into from
Oct 9, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 9, 2022

This is only ~5% but its a tiny change

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 81.56% // Head: 81.81% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (f27f0a4) compared to base (f554345).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   81.56%   81.81%   +0.25%     
==========================================
  Files          25       25              
  Lines        2935     2937       +2     
  Branches      566      566              
==========================================
+ Hits         2394     2403       +9     
+ Misses        333      328       -5     
+ Partials      208      206       -2     
Impacted Files Coverage Δ
src/dbus_fast/_private/unmarshaller.py 96.47% <100.00%> (+0.03%) ⬆️
src/dbus_fast/message_bus.py 73.19% <0.00%> (+0.76%) ⬆️
src/dbus_fast/proxy_object.py 78.52% <0.00%> (+2.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit b6d4069 into main Oct 9, 2022
@bdraco bdraco deleted the unmarh_header branch October 9, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant