Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disconnect race in tests #79

Merged
merged 3 commits into from
Oct 7, 2022
Merged

fix: disconnect race in tests #79

merged 3 commits into from
Oct 7, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 6, 2022

Fixes the test closing out the underlying fd and getting python confused which lead to random failures and segfaults

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 81.43% // Head: 81.46% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (88eb6e5) compared to base (18213c0).
Patch has no changes to coverable lines.

❗ Current head 88eb6e5 differs from pull request most recent head e52d276. Consider uploading reports for the commit e52d276 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   81.43%   81.46%   +0.03%     
==========================================
  Files          25       25              
  Lines        2930     2930              
  Branches      567      567              
==========================================
+ Hits         2386     2387       +1     
+ Misses        335      334       -1     
  Partials      209      209              
Impacted Files Coverage Δ
src/dbus_fast/aio/message_bus.py 86.72% <0.00%> (-0.89%) ⬇️
src/dbus_fast/message_bus.py 72.05% <0.00%> (-0.39%) ⬇️
src/dbus_fast/glib/message_bus.py 83.12% <0.00%> (+2.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review October 7, 2022 09:40
@bdraco bdraco merged commit f2bb106 into main Oct 7, 2022
@bdraco bdraco deleted the py311_fixes branch October 7, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant