Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cythonize unpack_variants #51

Merged
merged 3 commits into from
Oct 2, 2022
Merged

feat: cythonize unpack_variants #51

merged 3 commits into from
Oct 2, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 2, 2022

Provides an optional cython version of unpack_variants

@bdraco bdraco marked this pull request as ready for review October 2, 2022 19:35
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 81.20% // Head: 81.16% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (c0f0401) compared to base (f6e4c3c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   81.20%   81.16%   -0.05%     
==========================================
  Files          24       25       +1     
  Lines        2895     2899       +4     
  Branches      568      568              
==========================================
+ Hits         2351     2353       +2     
  Misses        335      335              
- Partials      209      211       +2     
Impacted Files Coverage Δ
src/dbus_fast/signature.py 57.20% <ø> (-1.45%) ⬇️
src/dbus_fast/__init__.py 100.00% <100.00%> (ø)
src/dbus_fast/aio/proxy_object.py 96.49% <100.00%> (ø)
src/dbus_fast/glib/proxy_object.py 82.94% <100.00%> (ø)
src/dbus_fast/proxy_object.py 76.51% <100.00%> (ø)
src/dbus_fast/unpack.py 100.00% <100.00%> (ø)
src/dbus_fast/message_bus.py 72.31% <0.00%> (-0.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit 1587211 into main Oct 2, 2022
@bdraco bdraco deleted the unpack_var branch October 2, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant