feat: add optional cython extension #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdraco
commented
Oct 1, 2022
•
bdraco
commented
- Improves performance by roughly 60%
- setup of the extension uses the recommended method in Allow optional compilation of C extensions python-poetry/poetry#2330 to degrade to pure python gracefully when it can't be compiled to ensure we keep the zero dep and pure Python 3 requirements
Codecov ReportBase: 81.08% // Head: 81.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 81.08% 81.12% +0.03%
==========================================
Files 24 24
Lines 2887 2893 +6
Branches 627 568 -59
==========================================
+ Hits 2341 2347 +6
Misses 335 335
Partials 211 211
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bdraco
force-pushed
the
add_optional_cython
branch
from
3ac9c77 to
f26bd00
Compare
|
The test need to be run with and without the C extension |
bdraco
force-pushed
the
add_optional_cython
branch
2 times, most recently
from
9b0df72 to
c1120c4
Compare
bdraco
force-pushed
the
add_optional_cython
branch
from
c1120c4 to
5d55e92
Compare
balloob
reviewed
Oct 1, 2022
bdraco
force-pushed
the
add_optional_cython
branch
from
93ad314 to
5f03047
Compare
dlech
reviewed
Oct 2, 2022
| @@ -48,7 +48,8 @@ Desktop users can use this library to create their own scripts and utilities to | |||
|
|
|||
| dbus-fast plans to improve over other DBus libraries for Python in the following ways: | |||
|
|
|||
| - Zero dependencies and pure Python 3. | |||
| - Zero dependencies and pure Python 3 | |||
There was a problem hiding this comment.
asyncio_timeout is a dependency, so we can no longer claim zero dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.