Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve unmarshaller performance #43

Merged
merged 1 commit into from
Sep 27, 2022
Merged

feat: improve unmarshaller performance #43

merged 1 commit into from
Sep 27, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 27, 2022

reduces the stack depth by making a factory
to build the parsers per ctype

This is roughly a 9% reduction

reduces the stack depth by making a factory
to build the parsers per ctype
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 81.00% // Head: 81.08% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (414c6c5) compared to base (076c5df).
Patch coverage: 93.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   81.00%   81.08%   +0.08%     
==========================================
  Files          24       24              
  Lines        2874     2887      +13     
  Branches      627      627              
==========================================
+ Hits         2328     2341      +13     
  Misses        335      335              
  Partials      211      211              
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/_private/unmarshaller.py 96.00% <96.77%> (+0.25%) ⬆️
src/dbus_fast/signature.py 58.64% <100.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review September 27, 2022 21:14
@bdraco bdraco merged commit c4b4a03 into main Sep 27, 2022
@bdraco bdraco deleted the stack_depth branch September 27, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant