Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve performance of marshalling message headers #356

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 7, 2025

We allow tuples now so we can construct tuples instead of lists as they are a bit faster

We allow tuples now so we can construct tuples instead
of lists as they are a bit faster
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (b1e6551) to head (29d36c6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          28       28           
  Lines        3341     3341           
  Branches      604      604           
=======================================
  Hits         2787     2787           
  Misses        346      346           
  Partials      208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #356 will not alter performance

Comparing marshall_construct (29d36c6) with main (b1e6551)

Summary

✅ 3 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review January 7, 2025 22:59
@bdraco bdraco merged commit e1aaf0a into main Jan 7, 2025
20 checks passed
@bdraco bdraco deleted the marshall_construct branch January 7, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant