Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve performance of unmarshalling variants #354

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 7, 2025

Screenshot 2025-01-07 at 12 59 39 PM

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.48%. Comparing base (e1aaf0a) to head (b3640db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   83.41%   83.48%   +0.06%     
==========================================
  Files          28       28              
  Lines        3341     3354      +13     
  Branches      604      604              
==========================================
+ Hits         2787     2800      +13     
  Misses        346      346              
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #354 will create unknown performance changes

Comparing unmarshall_var (b3640db) with main (e1aaf0a)

Summary

🆕 3 new benchmarks

Benchmarks breakdown

Benchmark main unmarshall_var Change
🆕 test_marshall_bluez_get_managed_objects_message N/A 73.2 µs N/A
🆕 test_unmarshall_bluez_properties_message N/A 45.5 µs N/A
🆕 test_unmarshall_bluez_rssi_message N/A 47.3 µs N/A

@bdraco bdraco merged commit d376bb1 into main Jan 7, 2025
14 checks passed
@bdraco bdraco deleted the unmarshall_var branch January 7, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant