Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build wheels for aarch64 to allow use in embedded systems #283

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

Mimoja
Copy link
Contributor

@Mimoja Mimoja commented Jun 26, 2024

As github runners can be used with qemu we simply emulate the aarch64 cpu needed to build for it. This allows faster installations on tradionally weaker embedded hardware.
The full aarch64 run roughly takes 90 minutes which should be taken into consideration if it is worth the occasional but additional time investment on release.

@Mimoja Mimoja force-pushed the merge branch 3 times, most recently from 83f43cb to a674342 Compare June 26, 2024 03:36
As github runners can be used with qemu we simply emulate the aarch64
cpu needed to build for it. This allows faster installations on tradionally
weaker embedded hardware.

Signed-off-by: Mimoja <[email protected]>
@Mimoja
Copy link
Contributor Author

Mimoja commented Jun 26, 2024

I dont think the python 3.7 failures are due to the PR. They also pop up on the previous HEAD
https://github.com/Mimoja/dbus-fast/actions/runs/9673188373/job/26686694693

@bdraco
Copy link
Member

bdraco commented Jun 26, 2024

I'll rip out 3.7 support later today if my flight isn't delayed

@bdraco
Copy link
Member

bdraco commented Jun 26, 2024

As github runners can be used with qemu we simply emulate the aarch64 cpu needed to build for it. This allows faster installations on tradionally weaker embedded hardware.

The full aarch64 run roughly takes 90 minutes which should be taken into consideration if it is worth the occasional but additional time investment on release.

It's no problem to do the aarch64 as well since the shell builds happen after the release and get uploaded lazily

@bdraco bdraco changed the title ci: Also build wheels for aarch64 to allow use in embedded systems feat: build wheels for aarch64 to allow use in embedded systems Jun 26, 2024
@bdraco bdraco self-requested a review June 26, 2024 05:59
@bdraco bdraco merged commit d0ac990 into Bluetooth-Devices:main Jun 26, 2024
16 checks passed
@bdraco
Copy link
Member

bdraco commented Jun 26, 2024

first build failed. I think #285 will fix it

@bdraco
Copy link
Member

bdraco commented Jun 26, 2024

@Mimoja
Copy link
Contributor Author

Mimoja commented Jun 26, 2024

Awesome. Thank you!

@Mimoja Mimoja deleted the merge branch June 26, 2024 20:38
@Mimoja
Copy link
Contributor Author

Mimoja commented Jun 26, 2024

Can confirm install working now perfectly fine on aarch64 musl and glibc. And it can now be installed on low memory systems which previously failed \0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants