fix: avoid expensive runtime inspection of known callables #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid calling _check_callback_type when we know the callable being passed is correct
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 83.42% 83.49% +0.06%
==========================================
Files 28 28
Lines 3295 3296 +1
Branches 684 685 +1
==========================================
+ Hits 2749 2752 +3
Misses 332 332
+ Partials 214 212 -2 ☔ View full report in Codecov by Sentry. |
QuintinHill
added a commit
to QuintinHill/openwrt-packages
that referenced
this pull request
Jan 26, 2024
fix: avoid expensive runtime inspection of known callables (Bluetooth-Devices/dbus-fast#277) Signed-off-by: Quintin Hill <[email protected]>
1715173329
pushed a commit
to openwrt/packages
that referenced
this pull request
Jan 29, 2024
fix: avoid expensive runtime inspection of known callables (Bluetooth-Devices/dbus-fast#277) Signed-off-by: Quintin Hill <[email protected]>
QuintinHill
added a commit
to QuintinHill/openwrt-packages
that referenced
this pull request
Jan 30, 2024
fix: avoid expensive runtime inspection of known callables (Bluetooth-Devices/dbus-fast#277) Signed-off-by: Quintin Hill <[email protected]> (cherry picked from commit 8db974d)
neheb
pushed a commit
to openwrt/packages
that referenced
this pull request
Feb 5, 2024
fix: avoid expensive runtime inspection of known callables (Bluetooth-Devices/dbus-fast#277) Signed-off-by: Quintin Hill <[email protected]> (cherry picked from commit 8db974d)
PeterFromSweden
pushed a commit
to PeterFromSweden/packages
that referenced
this pull request
Feb 10, 2024
fix: avoid expensive runtime inspection of known callables (Bluetooth-Devices/dbus-fast#277) Signed-off-by: Quintin Hill <[email protected]>
NoctivagusObitus
pushed a commit
to NoctivagusObitus/packages
that referenced
this pull request
Feb 22, 2024
fix: avoid expensive runtime inspection of known callables (Bluetooth-Devices/dbus-fast#277) Signed-off-by: Quintin Hill <[email protected]>
db260179
pushed a commit
to db260179/openwrt-packages
that referenced
this pull request
Mar 16, 2024
fix: avoid expensive runtime inspection of known callables (Bluetooth-Devices/dbus-fast#277) Signed-off-by: Quintin Hill <[email protected]> (cherry picked from commit 8db974d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid calling
_check_callback_typewhen we know the callable being passed is correct since they are created internally