feat: make ErrorType enums compare as strings #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 83.34% 83.28% -0.06%
==========================================
Files 28 28
Lines 3290 3291 +1
Branches 682 682
==========================================
- Hits 2742 2741 -1
- Misses 331 335 +4
+ Partials 217 215 -2 ☔ View full report in Codecov by Sentry. |
agners
force-pushed
the
make-error-type-inhert-str
branch
from
47e64fc to
f6a3cbf
Compare
bdraco
approved these changes
Nov 21, 2023
agners
force-pushed
the
make-error-type-inhert-str
branch
from
9d2b26b to
14be83e
Compare
The DBusError exception stores the error type as string. This makes the exception not directly compare to the ErrorType members (for example DBusError(ErrorType.FAILED, "").type != ErrorType.FAILED). This makes ErrorType also a string to make this comparision work.
agners
force-pushed
the
make-error-type-inhert-str
branch
from
14be83e to
2a23330
Compare
bdraco
changed the title
bdraco
approved these changes
Nov 21, 2023
|
I put this on my production Bluetooth env, and tested with bleak. I didn't see anything in the logs or unexpected side effects. The tests look good so feel free to merge if you are ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DBusError exception stores the error type as string. This makes the exception not directly compare to the ErrorType members (for example DBusError(ErrorType.FAILED, "").type != ErrorType.FAILED). This makes ErrorType also a string to make this comparision work.