Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up unpacking arrays #257

Merged
merged 2 commits into from
Sep 27, 2023
Merged

feat: speed up unpacking arrays #257

merged 2 commits into from
Sep 27, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 27, 2023

This is a 4% speed up on interfaces added

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0d7a665) 83.58% compared to head (7d257b9) 83.55%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   83.58%   83.55%   -0.03%     
==========================================
  Files          28       28              
  Lines        3283     3290       +7     
  Branches      682      682              
==========================================
+ Hits         2744     2749       +5     
- Misses        326      327       +1     
- Partials      213      214       +1     
Files Coverage Δ
src/dbus_fast/_private/unmarshaller.py 95.19% <100.00%> (+0.07%) ⬆️
src/dbus_fast/signature.py 62.44% <100.00%> (ø)
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 27, 2023 14:18
@bdraco bdraco merged commit 5c8bfe5 into main Sep 27, 2023
18 of 19 checks passed
@bdraco bdraco deleted the unpack_array_speed branch September 27, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant