Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cython typing for ServiceInterface.name #248

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 11, 2023

We compare this a lot so we want to force __Pyx_PyUnicode_Equals

We compare this a lot so we want to force __Pyx_PyUnicode_Equals
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.22% ⚠️

Comparison is base (8f39ba3) 83.60% compared to head (975dcd6) 83.38%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   83.60%   83.38%   -0.22%     
==========================================
  Files          28       28              
  Lines        3263     3263              
  Branches      677      677              
==========================================
- Hits         2728     2721       -7     
- Misses        324      328       +4     
- Partials      211      214       +3     
Files Changed Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/service.py 87.97% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 12, 2023 00:03
@bdraco bdraco merged commit 98c7e75 into main Sep 12, 2023
17 of 19 checks passed
@bdraco bdraco deleted the service_name branch September 12, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant