fix: spelling of dbus_fast.auth.AuthAnnonymous to dbus_fast.auth.AuthAnonymous
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 82.60% 82.73% +0.12%
==========================================
Files 27 27
Lines 3220 3221 +1
Branches 668 668
==========================================
+ Hits 2660 2665 +5
+ Misses 344 342 -2
+ Partials 216 214 -2
☔ View full report in Codecov by Sentry. |
|
This looks fine. Please add a test to make sure both names work so we do not regress this in the future by accident |
jimduchek
force-pushed
the
annonymous_fix
branch
from
7332dda to
a87bc04
Compare
|
Good call. Will add that now. |
jimduchek
force-pushed
the
annonymous_fix
branch
from
c93597e to
a35aeba
Compare
|
Think that's as good as it's gonna get... the codecov check is failing in a file I didn't touch, so not sure what that's about. |
bdraco
approved these changes
Aug 5, 2023
|
thanks @jimduchek |
bdraco
changed the title
dbus_fast.auth.AuthAnnonymous to dbus_fast.auth.AuthAnonymous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward. Don't think very many people use the ANONYMOUS auth, but included a line to keep backwards compatibility to not break anybody using the misspelled version.