Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception handler failure when exception is not DBusError #215

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 31, 2023

fixes

Traceback (most recent call last):
  File "src/dbus_fast/aio/message_reader.py", line 26, in dbus_fast.aio.message_reader.build_message_reader._message_reader
  File "src/dbus_fast/message_bus.py", line 807, in dbus_fast.message_bus.BaseMessageBus._process_message
  File "src/dbus_fast/message_bus.py", line 861, in dbus_fast.message_bus.BaseMessageBus._process_message
  File "src/dbus_fast/message_bus.py", line 83, in dbus_fast.message_bus.SendReply.__exit__
  File "src/dbus_fast/message_bus.py", line 64, in dbus_fast.message_bus.SendReply._exit
AttributeError: type object Exception has no attribute _as_message

fixes
```
Traceback (most recent call last):
  File "src/dbus_fast/aio/message_reader.py", line 26, in dbus_fast.aio.message_reader.build_message_reader._message_reader
  File "src/dbus_fast/message_bus.py", line 807, in dbus_fast.message_bus.BaseMessageBus._process_message
  File "src/dbus_fast/message_bus.py", line 861, in dbus_fast.message_bus.BaseMessageBus._process_message
  File "src/dbus_fast/message_bus.py", line 83, in dbus_fast.message_bus.SendReply.__exit__
  File "src/dbus_fast/message_bus.py", line 64, in dbus_fast.message_bus.SendReply._exit
AttributeError: type object Exception has no attribute _as_message
```
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: +0.11% 🎉

Comparison is base (5bda04b) 82.47% compared to head (aa18c42) 82.59%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   82.47%   82.59%   +0.11%     
==========================================
  Files          27       27              
  Lines        3212     3211       -1     
  Branches      666      665       -1     
==========================================
+ Hits         2649     2652       +3     
+ Misses        345      343       -2     
+ Partials      218      216       -2     
Files Changed Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/message_bus.py 72.34% <100.00%> (+0.49%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 1, 2023 20:00
@bdraco
Copy link
Member Author

bdraco commented Aug 1, 2023

manual testing looks good

@bdraco bdraco merged commit d771bcf into main Aug 1, 2023
@bdraco bdraco deleted the fix_exception_handler branch August 1, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant