Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrects Variant documentation #197

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

Mocramis
Copy link
Contributor

Variant documentation does not match the class signature since the fork from dbus-python.

It troubled me while reading the doc, so here is the (very small) fix.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 82.38% // Head: 82.31% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (fbaa5e9) compared to base (6387f82).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   82.38%   82.31%   -0.07%     
==========================================
  Files          27       27              
  Lines        3167     3167              
  Branches      654      654              
==========================================
- Hits         2609     2607       -2     
  Misses        343      343              
- Partials      215      217       +2     
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/signature.py 62.28% <ø> (ø)
src/dbus_fast/message_bus.py 71.48% <0.00%> (-0.37%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mocramis
Copy link
Contributor Author

Removed three lines of comments so coverage reduced :/ not sure how to fix that.

src/dbus_fast/signature.py Outdated Show resolved Hide resolved
@bdraco bdraco merged commit 9c6a472 into Bluetooth-Devices:main Feb 20, 2023
@bdraco
Copy link
Member

bdraco commented Feb 20, 2023

Thanks @Mocramis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants