-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: only construct handlers once #175
Conversation
This reverts commit 0ac1326.
Codecov ReportBase: 82.11% // Head: 82.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 82.11% 82.15% +0.03%
==========================================
Files 27 27
Lines 3137 3144 +7
Branches 647 649 +2
==========================================
+ Hits 2576 2583 +7
Misses 343 343
Partials 218 218
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Tested in production with passive scanning. Much better. There are still parts that search the whole message for fds and will never do anything. |
When bleak is using passive scanning each message would cause a method handler to be constructed via
_make_method_handler
Only construct them once.