Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unmarshaller cython typing for SignatureType and SignatureTree #168

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 17, 2022

No description provided.

@bdraco bdraco changed the title feat: add typing for SignatureType and SignatureTree feat: add unmarshaller cython typing for SignatureType and SignatureTree Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 82.27% // Head: 82.37% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (4d8e038) compared to base (1e32f28).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4d8e038 differs from pull request most recent head cd98ee9. Consider uploading reports for the commit cd98ee9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   82.27%   82.37%   +0.09%     
==========================================
  Files          27       27              
  Lines        3137     3137              
  Branches      647      647              
==========================================
+ Hits         2581     2584       +3     
+ Misses        340      338       -2     
+ Partials      216      215       -1     
Impacted Files Coverage Δ
src/dbus_fast/_private/unmarshaller.py 96.42% <100.00%> (ø)
src/dbus_fast/proxy_object.py 78.52% <0.00%> (+2.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review November 17, 2022 20:59
@bdraco bdraco merged commit 98d5c5a into main Nov 17, 2022
@bdraco bdraco deleted the signature_type_typing branch November 17, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant