Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optimized reader for GetManagedObjects #152

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 4, 2022

This is a 4% speed up

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 82.02% // Head: 82.11% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (edbb505) compared to base (2d56622).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head edbb505 differs from pull request most recent head 06bdc38. Consider uploading reports for the commit 06bdc38 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   82.02%   82.11%   +0.09%     
==========================================
  Files          27       27              
  Lines        3110     3126      +16     
  Branches      641      645       +4     
==========================================
+ Hits         2551     2567      +16     
  Misses        344      344              
  Partials      215      215              
Impacted Files Coverage Δ
src/dbus_fast/_private/unmarshaller.py 95.54% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member Author

bdraco commented Nov 4, 2022

Tested on production 👍

@bdraco bdraco merged commit 7ed453f into main Nov 4, 2022
@bdraco bdraco deleted the optimize_reader_getmanagedobjects branch November 4, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant