Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Marshaller performance #15

Merged
merged 7 commits into from
Sep 9, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 9, 2022

Current
(dbus-fast-3DfzHv5p-py3.10) bdraco@Js-MacBook-Pro dbus-fast % python3 bench/marshall.py
Marshalling 1000000 bluez get managed objects messages took 21.308216833043844 seconds

After
Marshalling 1000000 bluez get managed objects messages took 13.261790999909863 seconds

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #15 (7bbbed2) into main (e386e22) will decrease coverage by 0.20%.
The diff coverage is 96.49%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   72.58%   72.37%   -0.21%     
==========================================
  Files          24       24              
  Lines        2798     2795       -3     
  Branches      599      601       +2     
==========================================
- Hits         2031     2023       -8     
- Misses        573      587      +14     
+ Partials      194      185       -9     
Impacted Files Coverage Δ
src/dbus_fast/_private/marshaller.py 97.95% <95.45%> (-0.21%) ⬇️
src/dbus_fast/message.py 95.45% <100.00%> (+0.45%) ⬆️
src/dbus_fast/signature.py 57.20% <0.00%> (-2.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bdraco bdraco force-pushed the imporve_marshall_performance branch from 644aefe to 5880e49 Compare September 9, 2022 21:03
@bdraco bdraco marked this pull request as ready for review September 9, 2022 21:26
@bdraco bdraco merged commit a9e8866 into main Sep 9, 2022
@bdraco bdraco deleted the imporve_marshall_performance branch September 9, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant