Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor message_reader to avoid python wrappers #147

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 4, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 81.99% // Head: 82.21% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (3136c18) compared to base (6418ed4).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   81.99%   82.21%   +0.21%     
==========================================
  Files          27       27              
  Lines        3104     3103       -1     
  Branches      642      641       -1     
==========================================
+ Hits         2545     2551       +6     
+ Misses        343      340       -3     
+ Partials      216      212       -4     
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/aio/message_bus.py 85.78% <ø> (-0.40%) ⬇️
src/dbus_fast/_private/unmarshaller.py 95.33% <100.00%> (+0.05%) ⬆️
src/dbus_fast/aio/message_reader.py 91.30% <100.00%> (+0.39%) ⬆️
src/dbus_fast/message_bus.py 71.74% <0.00%> (+0.37%) ⬆️
src/dbus_fast/glib/message_bus.py 82.37% <0.00%> (+2.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member Author

bdraco commented Nov 4, 2022

With this last change we are down to almost no inner python and just converting data back to pyobjects at the integration points.

@bdraco bdraco marked this pull request as ready for review November 4, 2022 08:12
@bdraco bdraco merged commit b81de45 into main Nov 4, 2022
@bdraco bdraco deleted the cimport_message_reader_i branch November 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant