Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up creating Variant objects #144

Merged
merged 4 commits into from
Nov 3, 2022
Merged

feat: speed up creating Variant objects #144

merged 4 commits into from
Nov 3, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 3, 2022

This is only a 1.5% speed up but we create a lot of these

This is only a 1.5% speed up but we create a lot of
these
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 81.85% // Head: 81.93% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (3d87051) compared to base (f438c36).
Patch coverage: 90.00% of modified lines in pull request are covered.

❗ Current head 3d87051 differs from pull request most recent head 89bcef1. Consider uploading reports for the commit 89bcef1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   81.85%   81.93%   +0.07%     
==========================================
  Files          27       27              
  Lines        3109     3105       -4     
  Branches      643      642       -1     
==========================================
- Hits         2545     2544       -1     
+ Misses        347      344       -3     
  Partials      217      217              
Impacted Files Coverage Δ
src/dbus_fast/signature.py 62.28% <90.00%> (+3.32%) ⬆️
src/dbus_fast/glib/message_bus.py 80.32% <0.00%> (-2.05%) ⬇️
src/dbus_fast/_private/unmarshaller.py 95.29% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member Author

bdraco commented Nov 3, 2022

Tested in production 👍

@bdraco bdraco marked this pull request as ready for review November 3, 2022 21:53
@bdraco bdraco merged commit 2ff84e3 into main Nov 3, 2022
@bdraco bdraco deleted the variant branch November 3, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant