fix: pass return value to SendReply.__exit__ #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.85% // Head: 81.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 81.85% 81.65% -0.20%
==========================================
Files 27 27
Lines 3091 3091
Branches 597 597
==========================================
- Hits 2530 2524 -6
- Misses 342 347 +5
- Partials 219 220 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bdraco
reviewed
Oct 29, 2022
To return an error in a ServiceInterface, you raise a DBusError which is caught and translated to a message and sent over the bus. However, the context manager that catches this exception was incorrectly not sending a return value of True when the exception was handled. This caused the _message_reader() returned by build_message_reader() to log the error even though it was handled.
dlech
force-pushed
the
fix-dbus-error-not-supressed
branch
from
b62f5b8 to
fe91cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To return an error in a ServiceInterface, you raise a DBusError which is caught and translated to a message and sent over the bus. However, the context manager that catches this exception was incorrectly not sending a return value of True when the exception was handled. This caused the _message_reader() returned by build_message_reader() to log the error even though it was handled.