Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up unmarshaller with common signature trees #120

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 28, 2022

This is ~4%-6% speed up (there is some margin of error)

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 81.39% // Head: 81.18% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (2201659) compared to base (3eb123b).
Patch coverage: 93.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   81.39%   81.18%   -0.21%     
==========================================
  Files          27       27              
  Lines        3015     3024       +9     
  Branches      582      582              
==========================================
+ Hits         2454     2455       +1     
- Misses        347      353       +6     
- Partials      214      216       +2     
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/_private/unmarshaller.py 94.50% <100.00%> (+0.18%) ⬆️
src/dbus_fast/aio/message_reader.py 95.45% <0.00%> (-4.55%) ⬇️
src/dbus_fast/glib/message_bus.py 81.14% <0.00%> (-2.05%) ⬇️
src/dbus_fast/signature.py 56.76% <0.00%> (-0.44%) ⬇️
src/dbus_fast/message_bus.py 70.81% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member Author

bdraco commented Oct 28, 2022

Production testing 👍

@bdraco bdraco merged commit 5b32072 into main Oct 28, 2022
@bdraco bdraco deleted the prebuild_common_signature_trees branch October 28, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants